gh-115119: Removed bundled copy of the libmpdec#133964
gh-115119: Removed bundled copy of the libmpdec#133964skirpichev wants to merge 28 commits intopython:mainfrom
Conversation
skirpichev
force-pushed
the
remove-bundled-mpdecimal/115119
branch
from
7cba56a to
9d6c9b5
Compare
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
quick comments, haven't looked at build system changes
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skirpichev
force-pushed
the
remove-bundled-mpdecimal/115119
branch
from
0a33f9f to
2ba6b8b
Compare
Documentation build overview
6 files changed ·
|
skirpichev
force-pushed
the
remove-bundled-mpdecimal/115119
branch
from
ca84656 to
e0bdb87
Compare
skirpichev
requested review from
a team,
StanFromIreland,
corona10,
emmatyping,
ericsnowcurrently,
erlend-aasland,
ezio-melotti,
hugovk,
sethmlarson and
webknjaz
as code owners
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Mac/Buildscript/build-installer.py change LGTM
| * Remove the bundled libmpdec_ decimal library from the CPython source tree, | ||
| to simplify maintenence and updates. The :mod:`decimal` module will now | ||
| unconditionally use the system's libmpdec decimal library. Also remove the | ||
| now unused :option:`!--with-system-libmpdec` :program:`configure` flag. |
There was a problem hiding this comment.
We should probably mention that binary distributions will still include the _decimal module with libmpdec compiled in.
| decimal.so is not built from a static libmpdec.a since doing so led to | ||
| failures on AIX (user report) and Windows (mixing static and dynamic CRTs | ||
| causes locale problems and more). | ||
|
|
There was a problem hiding this comment.
Nit: most of this is out of date, and there are more extra blank lines at the top of the file.
There was a problem hiding this comment.
Are you OK with removal of this?
| # _FORTIFY_SOURCE wrappers for memmove and bcopy are incorrect: | ||
| # https://sourceware.org/ml/libc-alpha/2010-12/msg00009.html | ||
| AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -U_FORTIFY_SOURCE"]) | ||
| fi |
There was a problem hiding this comment.
Are these still relevant? Is LIBMPDEC_CFLAGS as a whole still relevant, or was it only for the building of libmpdec itself rather than the _decimal module?
There was a problem hiding this comment.
Hmm, probably also not. I see no memmove(), etc calls.
| [with_pydebug], [yes], | ||
| [AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -DTEST_COVERAGE"])]) | ||
|
|
||
| if test "$have_ipa_pure_const_bug" = yes; then |
There was a problem hiding this comment.
Regardless of the relevance question below, this is way above the definition down at line 7261.
There was a problem hiding this comment.
I think this case is not relevant anymore. The _decimal.c has not asm code.
| AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -fno-ipa-pure-const"]) | ||
| fi | ||
|
|
||
| if test "$have_glibc_memmove_bug" = yes; then |
| if test "$have_mpdec" = "no" | ||
| then | ||
| AS_VAR_SET([py_cv_module_]_decimal, [n/a]) | ||
| fi |
There was a problem hiding this comment.
There's a macro for this:
| if test "$have_mpdec" = "no" | |
| then | |
| AS_VAR_SET([py_cv_module_]_decimal, [n/a]) | |
| fi | |
| PY_STDLIB_MOD_SET_NA([_decimal]) |
It should probably go up with the have_mpdec definition, though.
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
4 participants
libmpdecsources #115119📚 Documentation preview 📚: https://cpython-previews--133964.org.readthedocs.build/